missing extensions are not ignored by default

Lines 174 to 179 in 606cc4d

    
           #### Extensions 
        
           By default, tests for the optional Array API extensions such as 
        
           [`linalg`](https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html) 
        
           will be skipped if not present in the specified array module. You can purposely 
        
           skip testing extension(s) via the `--disable-extension` option.

seems false. See https://github.com/mdhaber/marray/actions/runs/12521857195/job/34929420471?pr=47, which runs pytest -v -rxXfE --ci --max-examples=100 --derandomize --disable-deadline array_api_tests/

perhaps

array-api-tests/array_api_tests/test_has_names.py

Lines 26 to 28 in 606cc4d

    
           if category in EXTENSIONS: 
        
               ext_mod = getattr(xp, category) 
        
               assert hasattr(ext_mod, name), f"{xp.__name__} is missing the {category} extension function {name}()"

should be using enabled_extensions from here

array-api-tests/conftest.py

Lines 20 to 23 in 606cc4d

    
           disabled_extensions = config.getoption("--disable-extension") 
        
           enabled_extensions = sorted({ 
        
               ext for ext in EXTENSIONS + ['fft'] if ext not in disabled_extensions and xp_has_ext(ext) 
        
           })

it seems that test_has_names doesn't take --disable-extension into account when it is set either.

PR most welcome!

Navigation Menu

Repository navigation

missing extensions are not ignored by default #329

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	#### Extensions

	By default, tests for the optional Array API extensions such as
	[`linalg`](https://data-apis.org/array-api/latest/extensions/linear_algebra_functions.html)
	will be skipped if not present in the specified array module. You can purposely
	skip testing extension(s) via the `--disable-extension` option.

	if category in EXTENSIONS:
	ext_mod = getattr(xp, category)
	assert hasattr(ext_mod, name), f"{xp.__name__} is missing the {category} extension function {name}()"

	disabled_extensions = config.getoption("--disable-extension")
	enabled_extensions = sorted({
	ext for ext in EXTENSIONS + ['fft'] if ext not in disabled_extensions and xp_has_ext(ext)
	})

missing extensions are not ignored by default #329

Description

Activity

lucascolley commented on Dec 28, 2024

lucascolley commented on Dec 28, 2024

ev-br commented on Jan 1, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions