Add migration tables for NumPy as PyTorch#1004
Add migration tables for NumPy as PyTorch#1004mtsokol wants to merge 2 commits intodata-apis:mainfrom
Conversation
| how to use it. | ||
|
|
||
| ### NumPy | ||
|
|
There was a problem hiding this comment.
It may be good to start here that the Array API column uses xp. but all those calls works with np. as well - and usually it's more idiomatic NumPy anyway.
There was a problem hiding this comment.
That's right, I added a clarification.
| | `x.flatten` | `xp.reshape(x, (-1,))` | | | ||
|
|
||
| ### PyTorch | ||
|
|
There was a problem hiding this comment.
I think this needs a similar but slightly different note: most of the second column is available in PyTorch, but there are a few entries that rely on array-api-compat usage (which is the recommended way to add PyTorch support to a library that wants to use the array API).
There was a problem hiding this comment.
Right, for PyTorch we need array-api-compat in way more cases so I think it's better to require compat anyway for clarity.
|
ah yeah, really useful, just read through it |
3 participants
No description provided.