internal/cligen: format and normalize whitespace during generation#5562
Merged
Conversation
cligen now produces final output on its own, instead of leaning on a separate `task ws` pass and a `goimports`/`gofmt` subprocess. - Whitespace normalized in `renderToFile`; drops the `task ws` step. - Formatting moved in-process (`go/format` + unused-import prune); ~4.3s → ~0.3s. - Pruning never adds imports, so templates must keep their import lists complete. Co-authored-by: Isaac
Collaborator
|
Commit: f4d764c
22 interesting tests: 15 SKIP, 7 KNOWN
Top 28 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 9a0ddf9
458 interesting tests: 391 MISS, 28 RECOVERED, 22 FAIL, 8 KNOWN, 4 flaky, 3 PANIC, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cligen now produces final output on its own, instead of leaning on a separate
task wspass and agoimports/gofmtsubprocess.renderToFile; drops thetask wsstep.go/format+ unused-import prune); ~4.3s → ~0.3s.This pull request and its description were written by Isaac.