Fix pipeline allow_duplicate_names never converges - #6076
Merged
Conversation
allow_duplicate_names is only carried by CreatePipeline/EditPipeline; the pipelines GET API never returns it, so remote always reads back false. With allow_duplicate_names: true in config, every plan after a successful deploy reported the pipeline as an update that could never converge. The field is part of RemoteType via the embedded CreatePipeline, so the automatic missing_in_remote suppression does not apply. Declare it as input_only in ignore_remote_changes, next to run_as.
radakam
marked this pull request as ready for review
July 27, 2026 13:14
Collaborator
Integration test reportCommit: 173d1c0
8 interesting tests: 5 RECOVERED, 3 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik
approved these changes
Jul 30, 2026
radakam
enabled auto-merge
July 30, 2026 08:11
Collaborator
Integration test reportCommit: ff7ba4e
34 interesting tests: 16 flaky, 10 FAIL, 5 RECOVERED, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Declare pipeline
allow_duplicate_namesasinput_onlyinignore_remote_changes, next to the existingrun_asentry. Adds ano_driftinvariant config covering it.Why
The field is only carried by
CreatePipeline/EditPipelineand is never returned by GET, so remote always reads backfalse. Withallow_duplicate_names: true, every plan after a deploy reported a perpetual update (old: true, new: true— config unchanged, phantom remote drift). It's inRemoteTypevia the embeddedCreatePipeline, so the automaticmissing_in_remotesuppression doesn't apply.dry_runis request-only in the same way, butEditPipelinehas noDryRunfield, so it needs its own fix and is out of scope here.Tests
New
pipeline_allow_duplicate_names.yml.tmplinvariant config: fails onmain, passes with the fix. Also confirmed on dogfood — perpetual1 to changeacross three deploys before the fix, control pipeline without the field clean.