Turn provisioned-capacities -> pools - #6716
Merged
Merged
Conversation
vinchenzo-db
requested review from
ben-hansen-db and
maggiewang-db
and removed request for
maggiewang-db
September 16, 2026 17:55
maggiewang-db
approved these changes
Sep 16, 2026
| PriorityClass *string `yaml:"priority_class" help:"Scheduling priority within the reservation: BEST_EFFORT (lowest, preemptable), NORMAL, or CRITICAL (highest). Requires provisioned_capacity_id."` | ||
| NumAccelerators int `yaml:"num_accelerators" help:"Total number of GPUs to allocate. Must be a positive multiple of the accelerator type's per-node GPU count. See https://docs.databricks.com/aws/en/machine-learning/ai-runtime/cli/yaml-config#reference for supported GPU types."` | ||
| AcceleratorType string `yaml:"accelerator_type" help:"Which accelerator to run on, e.g. GPU_1xA10. See https://docs.databricks.com/aws/en/machine-learning/ai-runtime/cli/yaml-config#reference for the current list of supported GPU types. Matched case-sensitively."` | ||
| PoolID *string `yaml:"pool_id" help:"GPU pool to run on, by id. A GPU pool is a pre-provisioned accelerator reservation; contact your Databricks account team to provision one. Must be 1-255 characters. List available pools with 'air list pools'."` |
Contributor
There was a problem hiding this comment.
Does air list pools exist yet?
Product renamed the concept to "GPU pool", so the run YAML field that selects a reservation becomes compute.pool_id (hard rename, no back-compat alias). priority_class now reads "requires pool_id". The value is still sent on the wire as provisioned_capacity_id (the backend's name for a pool); only the user-facing YAML field changed. Updated help text, validation messages, tests, and the config-help / run-submit-deps acceptance goldens. Co-authored-by: Isaac <no-reply@databricks.com>
Carry the user-facing pool rename through to the Go internals of the submit path: provisionedCapacityID (variable and params) becomes poolID, and injectReservationFields becomes injectPoolFields. The on-wire key stays provisioned_capacity_id — that is the backend's contract, so only the Go identifiers and the concept wording in comments change, not any string sent to or parsed from the server. Co-authored-by: Isaac <no-reply@databricks.com>
vinchenzo-db
force-pushed
the
air-pool-id
branch
from
September 16, 2026 22:48
b901d25 to
cce5655
Compare
Collaborator
Integration test reportCommit: cce5655
Top 3 slowest tests (at least 2 minutes):
|
Collaborator
Integration test reportCommit: faf13ad
11 interesting tests: 8 flaky, 3 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Just a renaming to make commands shorter.
Why
Tests
Unit tests