[timcadman]

Issue

Previously CI didn't run DSLite, which meant some of the changes on v7.0-dev worked on real servers but not on DSLite. Cost to run on CI is small because it is very quick.

What's changed

• Broadened message assertion regex where DSLite was returning different message (alternative would be upstream change to dslite but this seeemed easier/lazier)
• Put in some if clauses where dslite has different behaviour
• Supressed warnings - this was causing some very long tests

[github-actions]

⏳ 4 of 5 checks reported so far

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 new findings (package total: 1926)
Armadillo unit tests	✅ [ FAIL 0 | WARN 0 | SKIP 21 | PASS 11809 ]
Opal unit tests	✅ [ FAIL 0 | WARN 0 | SKIP 21 | PASS 11417 ]
Test coverage	ℹ️ no coverable lines changed (project: 67.9%)

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.88%. Comparing base (b88f471) to head (2428f57).

Additional details and impacted files

@@              Coverage Diff              @@
##           v7.0-dev     #728       +/-   ##
=============================================
+ Coverage     47.55%   67.88%   +20.33%     
=============================================
  Files           131      131               
  Lines          5076     5076               
=============================================
+ Hits           2414     3446     +1032     
+ Misses         2662     1630     -1032     

Flag	Coverage Δ
armadillo-arg	20.58% <ø> (ø)
armadillo-misc	17.84% <ø> (ø)
armadillo-perf-1	10.59% <ø> (ø)
armadillo-perf-2	19.30% <ø> (ø)
armadillo-perf-3	18.42% <ø> (?)
armadillo-smk-1	41.68% <ø> (?)
armadillo-smk-2	35.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[StuartWheater]

A run time of 2h2m26s is a lot longer than I would expect with DSLite

[StuartWheater]

Has the error message checking been aligned with DSLite, Armadillo and Opal?