Repository navigation
chore: Force minimatch 11 for GHSA-g3hv-75wg-m249 - #629
Merged
Merged
Conversation
A crafted glob pattern can stall the process (medium). The fix exists only in minimatch 11.0.1+, and every parent asks for ^10 or older, so Dependabot cannot open a fix. Pin minimatch to 11.0.4 and glob to 14.0.3 in the package manager overrides. glob 13 bundles its own minimatch 10 copy, so forcing minimatch alone would leave the vulnerable code running inside glob; glob 14 bundles minimatch 11. The lock no longer holds any minimatch below 11 or glob below 14. No parent in the tree calls the APIs minimatch 11 removes (makeRe, regexp, AST, matchOne).
andrewb3000
approved these changes
Nov 8, 2026
kevwilliams
approved these changes
Nov 9, 2026
kevwilliams
left a comment
kevwilliams
left a comment
Contributor
There was a problem hiding this comment.
Verified the lock now resolves a single minimatch 11.0.4, with glob 14 depending on it, so no vulnerable copy remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot cannot fix minimatch GHSA-g3hv-75wg-m249 (medium, a crafted glob pattern can stall the process) in the consumer UI plugin, because the fix exists only in minimatch 11.0.1+ and its parent asks for
^10. This PR forces the fixed versions so the lock no longer carries a vulnerable minimatch.What changes
ui/consumer/pnpm-workspace.yamloverridesgainminimatch11.0.4 andglob14.0.3;ui/consumer/pnpm-lock.yamlis regenerated withpnpm install --lockfile-only --ignore-scripts(pnpm 11.28.9, the pinned version).path-scurry2.0.2 to 3.0.0 and the new@isaacs/nonrecursive-glob-matchthat glob 14 depends on.ui/providerhas no minimatch or glob in its lock and is untouched.Evidence
pnpm whyshows a single path,@sentry/vite-pluginto@sentry/bundler-pluginsto glob to minimatch (a dev dependency).makeRe,regexp,ASTandmatchOne. glob is the only consumer of minimatch in the tree and usesMinimatch#matchand escape helpers.@sentry/bundler-pluginscalls glob throughglob.glob(), which glob 14 still exports.pnpm run typecheck,pnpm test(353 of 353) andpnpm run buildpass on the new lock.