Add DLIB_CASSERT for optimization algorithms#3142
Open
KamalElFeniche wants to merge 1 commit intodavisking:masterfrom
Open
Add DLIB_CASSERT for optimization algorithms#3142KamalElFeniche wants to merge 1 commit intodavisking:masterfrom
KamalElFeniche wants to merge 1 commit intodavisking:masterfrom
Conversation
Owner
|
Thanks, but this might break existing users code. E.g. someone could, by the current contract, have a function that is giving nans and be just ignoring it and taking the best result they found that wasn't nan. Which by the current contract they are allowed to do. So better to let someone who doesn't want their objective to ever be nan to add that assert to their own output if that's what they want. |
Owner
|
Er, wait, sorry, just read the other thread. It segfaulted? That segfault should just be fixed. Can you post an example that causes the segfault? Although that other thread is very old. Did you observe a segfault? What bad thing does this fix exactly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an assert to check if the computed values are not NaNs. This is related to #1607.