Add support for -c/--command option to execute commands and exit - #1542
Merged
Conversation
This commit adds support for the -c/--command option to pgcli, similar to psql's behavior. Users can now execute SQL commands or internal commands from the command line and exit immediately after execution. Features: - Single command execution: pgcli -c "SELECT 1" - Multiple commands: pgcli -c "SELECT 1" -c "SELECT 2" - Long form: pgcli --command "SELECT 1" - Mixed usage: pgcli -c "cmd1" --command "cmd2" - Commands are executed sequentially - Pager is automatically disabled in command mode - Proper error handling and exit codes Tests included for all scenarios. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
DiegoDAF
marked this pull request as ready for review
December 5, 2025 18:22
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Address review feedback: the step decoded cmd_output into `output` but never used it (flagged by CodeQL as an unused local variable). It now asserts on the \dt column headers, which are rendered whether or not any tables exist, so the step verifies the special command actually produced its listing. Also drop the unused `as e` bindings in the TimeoutExpired handlers (ruff F841) and apply ruff format.
# Conflicts: # AUTHORS
# Conflicts: # pgcli/main.py
# Conflicts: # changelog.rst
# Conflicts: # changelog.rst # pgcli/main.py
behave's step registry is global, so now that -f landed and brought
tests/features/steps/file_option.py with it, the five steps this file
also defined ("we see the query result", "we see both query results",
"we see the command output", "we see an error message", "pgcli exits
successfully") raised AmbiguousStep and aborted the whole integration
run before any scenario executed.
Four of the five were byte-identical anyway; the fifth only differed in
a column name it looks for, and its assertion is an any() that already
matches on "SELECT". Dropping the duplicates here and reusing the ones
from file_option.py keeps every -c scenario passing.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
@DiegoDAF There are conflicts to resolve. |
# Conflicts: # changelog.rst # pgcli/main.py
Contributor
Author
|
Conflicts resolved, this is clean again and all checks are green. Two things came out of the merge that are worth flagging, since
Also dropped five behave steps this branch defined that |
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Sep 9, 2026
Contributor
|
Sounds good, let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
-c/--commandoption to pgcli, implementing psql-compatible behavior for executing SQL commands or internal commands from the command line.This is PR #1530, cleaned.
Features
pgcli -c "SELECT 1"pgcli -c "SELECT 1" -c "SELECT 2"pgcli --command "SELECT 1"pgcli -c "cmd1" --command "cmd2"Implementation Details
-c/--commandthat accepts multiple valuesrun_cli()to check for command mode and execute commands before entering interactive modeecho_via_pager()to disable pager when in command modehandle_watch_command()methodTesting
Comprehensive BDD tests included covering:
-cflag--commandflag-coptions-cand--commandoptionsCompatibility
This implementation follows psql's behavior and maintains backward compatibility with existing functionality.
Made with ❤️ and 🤖 Claude Code
Part of the feature list in discussion #1603: this is item 7 (
-c/--commandand-f/--file), the-chalf. The-fhalf is #1543.