Don't pass around a pointer to service.#209
Open
jholdstock wants to merge 2 commits into
Open
Conversation
It makes more sense for the functions to be methods of the service, rather than accepting the service as a param.
davecgh
reviewed
May 26, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
Nice update overall. It is cleaner to have the methods on the type and more customary to use a short name for receiver.
davecgh
reviewed
May 26, 2026
- Embed Mutex in struct to make it less verbose to use. - Avoid an extra lock by passing Vsp into vspStats as a param. - Add a missing lock in vspData.
davecgh
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes more sense for the functions to be methods of the service, rather than accepting the service as a param.