Skip to content

test(core): expect E44 on Windows when a refresh lands over 0.3.x - #131

Merged
dg-coreylweathers merged 1 commit into
mainfrom
fix/win-legacy-refresh-warning
Oct 9, 2026
Merged

dg-coreylweathers merged 1 commit into
mainfrom
fix/win-legacy-refresh-warning

Conversation

@dg-coreylweathers

@dg-coreylweathers dg-coreylweathers commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

main's test workflow fails on every Windows job since #126 and #130 met on main (test run 37930234857). One test, TestRecheckUnderLock::test_03x_only_tool_still_gets_folders_on_refresh[False].

Each PR was green on its own branch. #126 branched from 63c2be1, before #130 added E44.

Change

Test only, one commit. The test now has three named cases:

The Windows branch expects exactly one E44 naming the recorded path, with whitespace normalized on both sides so a console wrap cannot split the match. The POSIX branch expects empty stderr. Both then assert that the 0.3.x path left the record, only the two new skill folders remain listed, the v03 flag is cleared, and a second refresh prints nothing. On Windows a stale path would print E44 again, so that last check is load-bearing there.

Checked, on head e5cac81 (tree identical to be7a3ac, where the gate ran)

  • pytest -k TestRecheckUnderLock on macOS: 12 passed, including forced-windows.
  • Mutation check: with the cleanup's record rewrite disabled, native and forced-windows fail on the paths assertion; with the v03 flag left in place they fail on the flag assertion.
  • Docker gate (py3.12 ruff format, ruff check, mypy, full pytest; core tests on py3.10 and as uid 1000): all exit 0, 2207 passed.
  • ruff format --check on this test file reports blocks around lines 2312 and 2324 that are already unformatted on main and are not touched here. CI runs ruff format --check and ruff check on src/ and packages/*/src only, so test files are not formatted or linted in CI.

This is a test: commit, so release-please adds no changelog line.

🤖 Generated with Claude Code

@dg-coreylweathers
dg-coreylweathers force-pushed the fix/win-legacy-refresh-warning branch 4 times, most recently from 3e845a0 to 9bad985 Compare October 9, 2026 13:52
@dg-coreylweathers dg-coreylweathers changed the title test(core): expect the Windows E44 notice when a refresh lands over a 0.3.x record test(core): expect E44 on Windows when a refresh lands over 0.3.x Oct 9, 2026
@dg-coreylweathers
dg-coreylweathers force-pushed the fix/win-legacy-refresh-warning branch 5 times, most recently from 13589cd to be7a3ac Compare October 9, 2026 14:16
#126 asserted that landing new skill folders over a record written by deepctl 0.3.x
prints nothing. #130 made Windows skip the 0.3.x cleanup and print E44
once. Each passed on its own branch; together on main every Windows job
fails. The test now has three named cases: native, forced-windows (the
Windows branch on POSIX, skipped on Windows where native already is), and
removed. The Windows branch expects one E44 for the recorded path, the
POSIX branch silence, and both assert that the 0.3.x path leaves the
record, the v03 flag is cleared, and a second refresh prints nothing
(on Windows a stale path would print E44 again). Both sides of the E44
match normalize whitespace so a console wrap cannot split them. The
comment names deepctl as the actor: the cleanup runs after any tool's
folders land, from dg skills, dg login and dg plugin.
@dg-coreylweathers
dg-coreylweathers force-pushed the fix/win-legacy-refresh-warning branch from be7a3ac to e5cac81 Compare October 9, 2026 14:23
@dg-coreylweathers
dg-coreylweathers merged commit 04a3e0d into main Oct 9, 2026
43 checks passed
@dg-coreylweathers
dg-coreylweathers deleted the fix/win-legacy-refresh-warning branch October 9, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants