Add embedded terminal tabs - #624
Open
ph10w wants to merge 5 commits into
Open
Conversation
ph10w
marked this pull request as ready for review
July 29, 2026 09:00
Close temporary batch terminal tabs after script execution, split terminal responsibilities into focused classes, add terminal unit coverage, and make size-formatting tests locale-aware.
Owner
|
Hi ph10w, this looks like a more significant change, so I appreciate the work you've put into it. I think it needs some justification, though. Is there a particular reason why running a terminal embedded in a tab is better than running it externally? Also, is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The standard Open Command Prompt action now opens
cmd.exein an Explorer++ tab. Elevated terminals remain external, with the existing command prompt used as a fallback when the embedded terminal is unavailable. Activating.bator.cmdfiles opens a temporary terminal tab that closes when the script finishes.Architecture
HwndTerminalcontrol and connects it tocmd.exethrough ConPTY.Microsoft.Terminal.Control.dlldynamically from the application directory and includes it in portable and MSI packages with attribution.exit.Behavior
cdchanges in the tab title and tooltip, and closes interactive tabs when their command process exits.Checks performed
Explorer++andTestExplorer++inRelease|x64with 0 warnings and 0 errors.exit→ reopen, confirming that the path prompt appears immediately and remains usable.