[Docker-in-Docker] - Update docker-compose to the latest version#1672
Open
Kaniska244 wants to merge 1 commit into
Open
[Docker-in-Docker] - Update docker-compose to the latest version#1672Kaniska244 wants to merge 1 commit into
Kaniska244 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Docker-in-Docker dev container feature to make
latestthe default Docker Compose version.This change adds
latestas a supported value for thedockerDashComposeVersionoption, changes the default fromv2tolatest, and updates the feature metadata, install script defaults, README documentation, and test scenarios accordingly.Changes
docker-in-dockerfeature version from3.0.1to3.1.0.latestto the supporteddockerDashComposeVersionenum values.dockerDashComposeVersionfromv2tolatest.src/docker-in-docker/devcontainer-feature.jsonsrc/docker-in-docker/README.mdinstall.shso the default Docker Compose version islatest.dockerDashComposeVersion: "latest"with:Updated Behavior
Previously, when
dockerDashComposeVersionwas not explicitly set, the feature defaulted to:After this change, the feature defaults to:
The supported values are now:
Testing
Added new Docker-in-Docker test scenarios for Docker Compose
latest:docker_compose_latest_mobydocker_compose_latest_no_mobyThe new test verifies that:
docker compose versionreturns a valid semantic version.docker-compose --versionreturns a valid semantic version./usr/local/bin/docker-compose.Files Changed
src/docker-in-docker/devcontainer-feature.jsonsrc/docker-in-docker/install.shsrc/docker-in-docker/README.mdtest/docker-in-docker/scenarios.jsontest/docker-in-docker/docker_compose_latest_no_moby.shtest/docker-in-docker/docker_compose_latest_moby.sh