-
Notifications
You must be signed in to change notification settings - Fork 16
feat(hub-ui): support embedded viewer backgrounds #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antfu
merged 1 commit into
devframes:main
from
dvcolomban:codex/embedded-viewer-background
Sep 1, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
packages/hub-ui/src/client/standalone/viewer-background.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import type { ViewerBackgroundElement } from './viewer-background' | ||
| import { describe, expect, it, vi } from 'vitest' | ||
| import { applyViewerBackground } from './viewer-background' | ||
|
|
||
| function createElement(): ViewerBackgroundElement { | ||
| return { | ||
| style: { | ||
| removeProperty: vi.fn(), | ||
| setProperty: vi.fn(), | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| describe('applyViewerBackground', () => { | ||
| it('applies a supported CSS background', () => { | ||
| expect.assertions(3) | ||
|
|
||
| const element = createElement() | ||
| const supports = vi.fn(() => true) | ||
|
|
||
| applyViewerBackground(element, 'linear-gradient(white, transparent)', supports) | ||
|
|
||
| expect(supports).toHaveBeenCalledWith('background', 'linear-gradient(white, transparent)') | ||
| expect(element.style.setProperty).toHaveBeenCalledWith('--devframes-viewer-background', 'linear-gradient(white, transparent)') | ||
| expect(element.style.removeProperty).not.toHaveBeenCalled() | ||
| }) | ||
|
|
||
| it.each([undefined, 'not-a-background'])('restores the default for %s', (background) => { | ||
| expect.assertions(2) | ||
|
|
||
| const element = createElement() | ||
| const supports = vi.fn(() => false) | ||
|
|
||
| applyViewerBackground(element, background, supports) | ||
|
|
||
| expect(element.style.removeProperty).toHaveBeenCalledWith('--devframes-viewer-background') | ||
| expect(element.style.setProperty).not.toHaveBeenCalled() | ||
| }) | ||
| }) |
17 changes: 17 additions & 0 deletions
17
packages/hub-ui/src/client/standalone/viewer-background.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| export interface ViewerBackgroundElement { | ||
| style: Pick<CSSStyleDeclaration, 'removeProperty' | 'setProperty'> | ||
| } | ||
|
|
||
| /** Apply a validated branding background to the standalone viewer document. */ | ||
| export function applyViewerBackground( | ||
| documentElement: ViewerBackgroundElement, | ||
| background: string | undefined, | ||
| supports = (property: string, value: string): boolean => CSS.supports(property, value), | ||
| ): void { | ||
| if (background === undefined || !supports('background', background)) { | ||
| documentElement.style.removeProperty('--devframes-viewer-background') | ||
| return | ||
| } | ||
|
|
||
| documentElement.style.setProperty('--devframes-viewer-background', background) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.