You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Documentation: Misleading comment in event driven discovery #460
// Print based on whatever the event receiver outputs. Note that the event// receiver blocks, so in a real program, this should be run in its own// thread (not task, as this library does not yet use async channels).whileletSome(event) = events.next().await{
This comment is probably a relic from a time where instead of events.next().await there was a blocking call, right?
I can hardly imagine that events.next().await requires its own thread; this thread would require a new async reactor because it can no longer process .await calls. So I'm highly suspicious of this comment.
Also, the fact that events is some implementation of futures_core::stream::Stream, I question the validity of does not yet use async channels.
Activity
qdot commentedon Apr 12, 2026
Yuuuup, blame shows that as from 6 years ago, that's from the bad ol' days. Feel free to throw a PR for it, or I'll delete it at some point.
Finomnis commentedon Apr 12, 2026
It's not urgent, just wanted to report it.
docs: clarify peripheral properties and event discovery (#339 #460)
docs: document triaged bug fixes (#326 #339 #397 #422 #427 #460 #464 #…