Skip to content

docs updated on action trigger#24

Merged
Rupam-It merged 6 commits into
mainfrom
rupam/actiontrigger-docs
May 13, 2026
Merged

docs updated on action trigger#24
Rupam-It merged 6 commits into
mainfrom
rupam/actiontrigger-docs

Conversation

@Rupam-It

@Rupam-It Rupam-It commented May 6, 2026

Copy link
Copy Markdown
Collaborator

quick PR for actiontrigger field in workload policy for on_detection and on_schedule


Summary by Gitar

  • Documentation updates:
    • Replaced references to Karpenter with dzkarp across all SDK and primary documentation to reflect internal tool naming.
    • Updated NodePolicy configuration descriptions and code comments in TypeScript, Python, and Go examples to use correct dzkarp terminology.
    • Clarified parameter descriptions for nodePoolName, nodeClassName, and RawKarpenterSpecArgs fields in documentation tables.
  • Test automation:
    • Added scripts/test-packages.sh to automate end-to-end testing of typescript, go, and python SDK examples using Pulumi.
    • Updated scripts/test-packages.sh to support TypeScript dependencies, including npm install and npm run build steps.

This will update automatically on new commits.

Comment thread scripts/test-packages.sh
Comment thread scripts/test-packages.sh
# Export them in your shell or pass them inline:
# export DEVZERO_TEAM_ID=team-xxx
# export DEVZERO_TOKEN=dzu-xxx ./scripts/test-examples.sh
# export DEVZERO_URL is optional – defaults to https://dakr.devzero.io

@gitar-bot gitar-bot Bot May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Bug: Comment says default URL is .io but code defaults to .dev

Line 12 comments that DEVZERO_URL defaults to https://dakr.devzero.io, but line 16 actually defaults to https://dakr.devzero.dev. This mismatch could confuse developers running the script.

Update the comment to match the actual default value:

# export  DEVZERO_URL is optional – defaults to https://dakr.devzero.dev

Was this helpful? React with 👍 / 👎

@gitar-bot

gitar-bot Bot commented May 13, 2026

Copy link
Copy Markdown
Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Updates documentation to reflect dzkarp terminology and adds automated SDK integration testing. Please correct the DEVZERO_URL default documentation to match the .dev code implementation.

💡 Bug: Comment says default URL is .io but code defaults to .dev

📄 scripts/test-packages.sh:12 📄 scripts/test-packages.sh:16

Line 12 comments that DEVZERO_URL defaults to https://dakr.devzero.io, but line 16 actually defaults to https://dakr.devzero.dev. This mismatch could confuse developers running the script.

Update the comment to match the actual default value
# export  DEVZERO_URL is optional – defaults to https://dakr.devzero.dev
✅ 1 resolved
Bug: Missing npm/yarn install step for TypeScript tests

📄 scripts/test-packages.sh:48-60
The run_language_test function has pre-build steps for go (go build) and python (pip install), but no equivalent npm install / yarn install for typescript. TypeScript Pulumi projects require their node_modules to be installed before pulumi up can run, so the typescript test will fail with missing dependencies.

🤖 Prompt for agents
Code Review: Updates documentation to reflect dzkarp terminology and adds automated SDK integration testing. Please correct the DEVZERO_URL default documentation to match the .dev code implementation.

1. 💡 Bug: Comment says default URL is .io but code defaults to .dev
   Files: scripts/test-packages.sh:12, scripts/test-packages.sh:16

   Line 12 comments that `DEVZERO_URL` defaults to `https://dakr.devzero.io`, but line 16 actually defaults to `https://dakr.devzero.dev`. This mismatch could confuse developers running the script.

   Fix (Update the comment to match the actual default value):
   # export  DEVZERO_URL is optional – defaults to https://dakr.devzero.dev

Was this helpful? React with 👍 / 👎 | Gitar

@Rupam-It Rupam-It merged commit 9fb79da into main May 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant