docs updated on action trigger#24
Conversation
| # Export them in your shell or pass them inline: | ||
| # export DEVZERO_TEAM_ID=team-xxx | ||
| # export DEVZERO_TOKEN=dzu-xxx ./scripts/test-examples.sh | ||
| # export DEVZERO_URL is optional – defaults to https://dakr.devzero.io |
There was a problem hiding this comment.
💡 Bug: Comment says default URL is .io but code defaults to .dev
Line 12 comments that DEVZERO_URL defaults to https://dakr.devzero.io, but line 16 actually defaults to https://dakr.devzero.dev. This mismatch could confuse developers running the script.
Update the comment to match the actual default value:
# export DEVZERO_URL is optional – defaults to https://dakr.devzero.dev
Was this helpful? React with 👍 / 👎
Code Review 👍 Approved with suggestions 1 resolved / 2 findingsUpdates documentation to reflect dzkarp terminology and adds automated SDK integration testing. Please correct the DEVZERO_URL default documentation to match the .dev code implementation. 💡 Bug: Comment says default URL is .io but code defaults to .dev📄 scripts/test-packages.sh:12 📄 scripts/test-packages.sh:16 Line 12 comments that Update the comment to match the actual default value✅ 1 resolved✅ Bug: Missing npm/yarn install step for TypeScript tests
🤖 Prompt for agentsWas this helpful? React with 👍 / 👎 | Gitar |
quick PR for actiontrigger field in workload policy for on_detection and on_schedule
Summary by Gitar
Karpenterwithdzkarpacross all SDK and primary documentation to reflect internal tool naming.NodePolicyconfiguration descriptions and code comments in TypeScript, Python, and Go examples to use correctdzkarpterminology.nodePoolName,nodeClassName, andRawKarpenterSpecArgsfields in documentation tables.scripts/test-packages.shto automate end-to-end testing oftypescript,go, andpythonSDK examples using Pulumi.scripts/test-packages.shto support TypeScript dependencies, includingnpm installandnpm run buildsteps.This will update automatically on new commits.