Skip to content

Optional parameter minSupportedVersion for tls.createConnection()#283

Closed
rachid-o wants to merge 2 commits into
digitalbazaar:masterfrom
rachid-o:minSupportedVersion
Closed

Optional parameter minSupportedVersion for tls.createConnection()#283
rachid-o wants to merge 2 commits into
digitalbazaar:masterfrom
rachid-o:minSupportedVersion

Conversation

@rachid-o
Copy link
Copy Markdown

@rachid-o rachid-o commented Aug 5, 2015

Added optional paramter minSupportedVersion to tls.createConnection(). This parameter specifies which TLS protocol should be supported at minimum by the other side.
We use this to explicitly disable TLS v1.0.

Rachid Ben Moussa added 2 commits August 5, 2015 11:48
@dlongley
Copy link
Copy Markdown
Member

dlongley commented Aug 5, 2015

Forge 0.7.x (which is presently being developed on this branch that needs renaming: https://github.com/digitalbazaar/forge/tree/buffer-based-api) already has a feature to be explicit about the version you want to use when connecting. It was first introduced here: e12da76, be6a024 but may have a few other changes later down the line.

To get support for this in 0.6.x, a backport that cherry picks what's needed should be performed. If any additional checks are necessary, we can layer those on top.

@dlongley
Copy link
Copy Markdown
Member

dlongley commented Aug 5, 2015

There may be some differences in the semantics of 0.7.x's options.version and what's provided here, so a closer look may be required to either reconcile them or ensure all common use cases around selecting a version are supported.

@dlongley
Copy link
Copy Markdown
Member

Replaced by #387.

@dlongley dlongley closed this Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants