Load GAPDoc for the tests - #944
Open
fingolfin wants to merge 1 commit into
Open
Conversation
tst/teststandard.g runs DigraphsTestManualExamples, which extracts the
examples from the manual and therefore needs GAPDoc. GAPDoc is only a
suggested package of Digraphs, so in a GAP where it is not loaded, e.g.
one started with `gap --bare', the test run ended with
Error, Variable: 'ExtractExamples' must have an assigned value
Declare GAPDoc in TestPackages and load it in tst/teststandard.g. Note
that TestPackages alone does not suffice: it makes the CI install the
package, but does not load it.
Digraphs itself does not need GAPDoc; all of its uses are in the test and
documentation helpers in gap/utils.gi.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 50 50
Lines 21189 21189
Branches 639 639
=======================================
Hits 20649 20649
Misses 475 475
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tst/teststandard.g runs DigraphsTestManualExamples, which extracts the
examples from the manual and therefore needs GAPDoc. GAPDoc is only a
suggested package of Digraphs, so in a GAP where it is not loaded, e.g.
one started with `gap --bare', the test run ended with
Declare GAPDoc in TestPackages and load it in tst/teststandard.g. Note
that TestPackages alone does not suffice: it makes the CI install the
package, but does not load it.
Digraphs itself does not need GAPDoc; all of its uses are in the test and
documentation helpers in gap/utils.gi.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 noreply@anthropic.com