vendor: golang.org/x/net v0.56.0#7049
Conversation
full diff: golang/net@v0.55.0...v0.56.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR bumps golang.org/x/net from v0.55.0 to v0.56.0. The substantive changes are in two vendored wrapper files:
vendor/golang.org/x/net/http2/server_wrap.go — configureServer now initializes s.TLSConfig (if nil) and registers ALPN protocols (h2, http/1.1) on it. The idempotency guards via slices.Contains prevent double-registration. This matches the pre-wrapping behavior in server.go and is a correctness fix to ensure TLS listeners built from s.TLSConfig still negotiate HTTP/2.
vendor/golang.org/x/net/http2/transport_wrap.go — configureTransport was previously a no-op; it now calls configureTransports. The new code:
- Preserves any existing
TLSClientConfig(only creates an empty one if nil) - Initializes
t1.Protocolswith HTTP/1.1 only if nil, then unconditionally enables HTTP/2
Both changes replicate the behavior of the non-wrapped upstream implementation and address cases where net/http does not auto-enable HTTP/2 for transports with custom TLS config or dialers. No regressions identified in the added lines.
full diff: golang/net@v0.55.0...v0.56.0
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)