test(tui): freeze the animation clock in the scrolled-up stream program test - #4289
Merged
Merged
Conversation
…am test Under -race the real program loop is slow enough for a spinner tick to land inside the measured window and add a third composition to the "at most two" assertion (main run 34831078454). Same fix as #4228 for the other exact-count program tests: build the root on the frozen scheduler.
dgageot
approved these changes
Sep 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 14, 2026
aheritier
added
area/tui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
test-racefailed on main (run 34831078454):The test drives a real bubbletea program on the wall-clock animation runtime and asserts at most two compositions while an off-screen stream is deferred. Under
-racethe loop is slow enough (15 s here) for a spinner tick to land inside the window and add a composition. No data race was reported. This is the class of failure #4228 fixed for the other exact-count program tests by moving them tofrozenClockRoot; this test was not covered.What
wallClockRoot→frozenClockRoot, as in #4228. The test still exercises the real program loop; only the animation clock stops advancing.Locally:
go test -race -count=3 -run TestActualProgramScrolledUpStreamDefersOffscreenTail ./pkg/tui/passes. The failure did not reproduce locally on the wall clock in 6 runs (4 s each vs 15 s in CI), consistent with a CI-speed-dependent tick.