Allow llama.cpp reasoning preservation flags - #1032
Open
cmizzi wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--reasoning-preserveand--no-reasoning-preserveto thellama.cppruntime flag allowlist.These flags are supported by
llama.cppand are boolean-only options. They do not access files or external resources, so they fit the existing security model used for runtime flag validation.--reasoning-preserveis important for reasoning models because it keeps the reasoning trace in the conversation history, allowing prompt/KV cache reuse when combined with prompt caching.Without this change, Docker Model Runner rejects the flags before
llama.cppis started.