Skip to content

Allow llama.cpp reasoning preservation flags - #1032

Open
cmizzi wants to merge 1 commit into
docker:mainfrom
cmizzi:feat/allow-reasoning-preserve
Open

Allow llama.cpp reasoning preservation flags#1032
cmizzi wants to merge 1 commit into
docker:mainfrom
cmizzi:feat/allow-reasoning-preserve

Conversation

@cmizzi

@cmizzi cmizzi commented Aug 4, 2026

Copy link
Copy Markdown

This PR adds --reasoning-preserve and --no-reasoning-preserve to the llama.cpp runtime flag allowlist.

These flags are supported by llama.cpp and are boolean-only options. They do not access files or external resources, so they fit the existing security model used for runtime flag validation. --reasoning-preserve is important for reasoning models because it keeps the reasoning trace in the conversation history, allowing prompt/KV cache reuse when combined with prompt caching.

Without this change, Docker Model Runner rejects the flags before llama.cpp is started.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant