Skip to content

Add XML documentation for DatePicker DateTime properties - #12306

Open
jonathanpeppers with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-finder-add-xml-documentation
Open

Add XML documentation for DatePicker DateTime properties#12306
jonathanpeppers with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-finder-add-xml-documentation

Conversation

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The .NET-friendly DatePicker date properties lacked IntelliSense guidance about month indexing and Android millisecond timestamps.

  • DateTime

    • Document the .NET 1-based to Android 0-based month conversion.
    • Clarify that only year, month, and day are used.
  • MinDateTime and MaxDateTime

    • Document conversion from Android milliseconds relative to January 1, 1970.
  • API references

    • Link each property to the relevant official Android DatePicker documentation.

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add XML documentation to DatePicker DateTime properties Add XML documentation for DatePicker DateTime properties Aug 6, 2026
Copilot AI requested a review from jonathanpeppers August 6, 2026 02:46
@jonathanpeppers
jonathanpeppers marked this pull request as ready for review August 7, 2026 13:30
Copilot AI review requested due to automatic review settings August 7, 2026 13:30
@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds missing XML documentation to the handwritten, .NET-friendly Android.Widget.DatePicker date properties in Mono.Android.dll, improving IntelliSense guidance around month indexing and Android millisecond-based date values (fixes #12305).

Changes:

  • Added <summary> / <remarks> for DatePicker.DateTime explaining .NET 1-based vs Android 0-based month conversion and that only year/month/day are used when setting.
  • Added <summary> / <value> for MinDateTime and MaxDateTime describing conversion from Android’s millisecond-based date values.
  • Added <seealso> links to the relevant official Android DatePicker reference pages.
Suppressed comments (1)

src/Mono.Android/Android.Widget/DatePicker.cs:25

  • 🤖 💡 Documentation — Same as getMinDate(): Android’s DatePicker.getMaxDate() is defined in terms of milliseconds since Jan 1, 1970 00:00:00 in the device’s default time zone. The <value> text would be clearer if it included the time zone context.
		/// <summary>Gets the maximum selectable date supported by this picker.</summary>
		/// <value>The maximum date converted from Android's millisecond value relative to January 1, 1970.</value>
		/// <seealso href="https://developer.android.com/reference/android/widget/DatePicker#getMaxDate()">Android documentation for <c>android.widget.DatePicker.getMaxDate</c></seealso>

Comment thread src/Mono.Android/Android.Widget/DatePicker.cs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 7, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix-finder] Add XML documentation to DatePicker DateTime properties

3 participants