Add XML documentation for DatePicker DateTime properties - #12306
Open
jonathanpeppers with Copilot wants to merge 3 commits into
Open
Add XML documentation for DatePicker DateTime properties#12306jonathanpeppers with Copilot wants to merge 3 commits into
jonathanpeppers with Copilot wants to merge 3 commits into
Conversation
7 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add XML documentation to DatePicker DateTime properties
Add XML documentation for DatePicker DateTime properties
Aug 6, 2026
jonathanpeppers
marked this pull request as ready for review
August 7, 2026 13:30
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing XML documentation to the handwritten, .NET-friendly Android.Widget.DatePicker date properties in Mono.Android.dll, improving IntelliSense guidance around month indexing and Android millisecond-based date values (fixes #12305).
Changes:
- Added
<summary>/<remarks>forDatePicker.DateTimeexplaining .NET 1-based vs Android 0-based month conversion and that only year/month/day are used when setting. - Added
<summary>/<value>forMinDateTimeandMaxDateTimedescribing conversion from Android’s millisecond-based date values. - Added
<seealso>links to the relevant official AndroidDatePickerreference pages.
Suppressed comments (1)
src/Mono.Android/Android.Widget/DatePicker.cs:25
- 🤖 💡 Documentation — Same as
getMinDate(): Android’sDatePicker.getMaxDate()is defined in terms of milliseconds since Jan 1, 1970 00:00:00 in the device’s default time zone. The<value>text would be clearer if it included the time zone context.
/// <summary>Gets the maximum selectable date supported by this picker.</summary>
/// <value>The maximum date converted from Android's millisecond value relative to January 1, 1970.</value>
/// <seealso href="https://developer.android.com/reference/android/widget/DatePicker#getMaxDate()">Android documentation for <c>android.widget.DatePicker.getMaxDate</c></seealso>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jonathanpeppers
enabled auto-merge (squash)
August 7, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .NET-friendly
DatePickerdate properties lacked IntelliSense guidance about month indexing and Android millisecond timestamps.DateTimeMinDateTimeandMaxDateTimeAPI references
DatePickerdocumentation.