Skip to content

More thorough check of framework description for .NET 6+ #12308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chagrins wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

More thorough check of framework description for .NET 6+ #12308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
292d9da
More thorough check of framework description for .NET 6+
Chagrins Jul 23, 2026
45722f5
Target major version less than 6
Chagrins Aug 7, 2026
f914be1
Update src/Xamarin.Android.Build.Tasks/Tasks/BuildArchive.cs
jonathanpeppers Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Xamarin.Android.Build.Tasks/Tasks/BuildArchive.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ bool ShouldFallbackToLibZipSharp ()
// Always fallback on .NET Framework
var frameworkDescription = RuntimeInformation.FrameworkDescription;
Log.LogDebugMessage ($"RuntimeInformation.FrameworkDescription: {frameworkDescription}");
if (frameworkDescription != ".NET") {
Log.LogDebugMessage ("Falling back to LibZipSharp because we are *not* running on .NET 6+.");
if (Environment.Version.Major < 6) {
Comment thread
jonathanpeppers marked this conversation as resolved.
Log.LogDebugMessage ($"Falling back to LibZipSharp because we are *not* running on .NET 6+, Environment.Version.Major: {Environment.Version.Major}");
return true;
}

Expand Down