Replace all occurences of redundant spacing in if condition#54405
Open
BartoszKlonowski wants to merge 2 commits into
Open
Replace all occurences of redundant spacing in if condition#54405BartoszKlonowski wants to merge 2 commits into
BartoszKlonowski wants to merge 2 commits into
Conversation
BillWagner
approved these changes
Jun 16, 2026
BillWagner
left a comment
Member
There was a problem hiding this comment.
This LGTM @BartoszKlonowski
Pending any unexpected CI errors, I'll ![]()
auto-merge was automatically disabled
June 16, 2026 17:33
Head branch was pushed to by a user without write access
Contributor
Author
|
@BillWagner I've (naively) added missing cscproj'es, but I saw that there really is couple of |
Contributor
|
The new snippet build system isn't designed for the old snippets. I wouldn't worry about it because you're playing cat-and-mouse trying to fit it in and if you're going to spend time doing that, you should just move them to the new system. |
Contributor
Author
Means we want to migrate them to a single |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #54380 along with other cases where the same problem exists.
This commit replaces all (29 in total as per grep results count):
if (! condition)with
if (!condition)according to the general formatting in the code base.
From what I saw, this typo happens mostly in old (couple of years even) files, and was there when migrated from samples repository.
Internal previews