Skip to content

Add regression test: #14454, IAsyncDisposable use in task CE in FSI - #20251

Merged
T-Gro merged 2 commits into
mainfrom
regression-test/issue14454-8fdfbbd9ec8f28a8
Aug 13, 2026
Merged

Add regression test: #14454, IAsyncDisposable use in task CE in FSI#20251
T-Gro merged 2 commits into
mainfrom
regression-test/issue14454-8fdfbbd9ec8f28a8

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Adds a regression test for #14454use with IAsyncDisposable inside a task {} computation expression in FSI now correctly resolves the async disposal overload.

The bug was that FSI loaded the netstandard2.0 FSharp.Core which lacked the IAsyncDisposable-aware TaskBuilderBase.Using overload (gated behind #if NETSTANDARD2_1). This has been fixed on main — FSI now targets net11.0 and includes the overload.

The test evaluates a script that creates an IAsyncDisposable and uses it with use in a task {} CE, verifying it type-checks and evaluates successfully.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • southcentralus0.in.applicationinsights.azure.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "southcentralus0.in.applicationinsights.azure.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@7c7feb61a52b662eb2089aa2945588b7a200d404

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes labels Aug 13, 2026
@github-actions
github-actions Bot requested a review from a team as a code owner August 13, 2026 01:21
@github-actions github-actions Bot added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes AI-Issue-Regression-PR PR adding regression test for a closed issue labels Aug 13, 2026
@github-actions
github-actions Bot requested review from T-Gro and abonie August 13, 2026 01:21
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Aug 13, 2026
IAsyncDisposable requires .NET Standard 2.1+ and is not available on
.NET Framework Desktop, causing test failures in Desktop CI jobs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor Author

Commit pushed: cb9db44

Generated by Regression PR Shepherd · opus46 4.3M

@github-actions

Copy link
Copy Markdown
Contributor Author

🤖 This is an automated response from Regression PR Shepherd.

CI failures in WindowsNoRealsig_testDesktop and WindowsCompressedMetadata_Desktop Batch1 were caused by IAsyncDisposable not being available on .NET Framework Desktop (requires .NET Standard 2.1+).

Fixed by changing [<Fact>] to [<FSharp.Test.FactForNETCOREAPP>] so the test only runs on .NET Core.

Generated by Regression PR Shepherd · opus46 4.3M ·

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Aug 13, 2026
@T-Gro
T-Gro merged commit 5d6e4dc into main Aug 13, 2026
47 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Aug 13, 2026
@T-Gro
T-Gro deleted the regression-test/issue14454-8fdfbbd9ec8f28a8 branch August 13, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Issue-Regression-PR PR adding regression test for a closed issue AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant