Skip to content

Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command#126789

Open
Copilot wants to merge 2 commits intomainfrom
copilot/fix-wasmtest-on-chrome
Open

Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command#126789
Copilot wants to merge 2 commits intomainfrom
copilot/fix-wasmtest-on-chrome

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

Description

WasmTestOnChrome and related WASM CI jobs were failing because gen-debug-dump-docs.py was scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload for browser/wasi targets.

Changes

  • src/libraries/sendtohelixhelp.proj: Added browser and wasi exclusions to the non-Windows HelixPostCommands condition for gen-debug-dump-docs.py, consistent with the existing pattern already used for TestEnvFileName in the same file:
<!-- Before -->
<HelixPostCommands Condition="'$(TargetOS)' != 'windows'">

<!-- After -->
<HelixPostCommands Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi'">

Changes

  • src/libraries/sendtohelixhelp.proj

Testing

Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.

Fixes #126706

Copilot AI requested review from Copilot and removed request for Copilot April 11, 2026 14:29
Copilot AI linked an issue Apr 11, 2026 that may be closed by this pull request
…ion in sendtohelixhelp.proj

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/03016fca-f49c-41ad-9a70-5edc812bb5d8

Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot April 11, 2026 14:33
Copilot AI changed the title [WIP] Fix WasmTestOnChrome build error regarding gen-debug-dump-docs.py Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command Apr 11, 2026
Copilot AI requested a review from danmoseley April 11, 2026 14:34
@danmoseley danmoseley requested a review from vitek-karas April 11, 2026 19:08
@danmoseley danmoseley marked this pull request as ready for review April 11, 2026 19:08
Copilot AI review requested due to automatic review settings April 11, 2026 19:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.

Changes:

  • Update the non-Windows HelixPostCommands condition to exclude browser and wasi, avoiding a missing-script failure on those targets.
Show a summary per file
File Description
src/libraries/sendtohelixhelp.proj Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WasmTestOnChrome: can't open file gen-debug-dump-docs.py

3 participants