Stabilize configuration polling reload tests - #131876
Open
svick wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aeb5f2a3-ce48-4327-a355-0960afe29610
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes Microsoft.Extensions.Configuration functional reload-on-change tests on platforms that rely on polling-based file change detection, by ensuring overwrite operations reliably advance LastWriteTimeUtc so PollingFileChangeToken can observe changes.
Changes:
- Added a polling-aware helper (
WriteFilesForReload) that delays writes whenPhysicalFileProvider.UseActivePollingis in effect and asserts timestamps actually changed. - Updated overwrite-based reload tests to use the helper to avoid same-timestamp overwrites.
- Removed remaining
ActiveIssuesuppressions that referenced #42036 in this test file.
tarekgh
added
area-Extensions-FileSystem
and removed
area-Extensions-Configuration
labels
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-filesystem |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Aug 7, 2026
Member
Author
|
/ba-g Remaining failure is unrelated (it's #122522) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131805.
Description
PollingFileChangeTokendetects overwrites throughLastWriteTimeUtc. On platforms that use active polling, rapid test writes can retain the previous timestamp and the change is never observed.This change:
PhysicalFileProviderActiveIssueattributes for Using FileWatcher on non-windows has a very large impact on startup time #42036Note
This pull request description was drafted with GitHub Copilot.