Conversation
…I cocoa crash gracefully
9244410 to
8e140f4
Compare
Member
Author
|
@copilot review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is focused on adjusting CI behavior and test execution stability, while also improving PDF native library loading (notably for macOS arm64) and adding test categorization for PDF-related tests.
Changes:
- Overhauled the GitHub Actions workflow into a multi-job CI with OS/framework matrix testing, artifacts, and an “alls-green” gate.
- Updated the test project to add GitHub Actions logging support, disable xUnit parallelism via
xunit.runner.json, and adjust target frameworks (drop net7.0, add net9.0). - Added PDF test categorization traits and introduced a
DllImportResolverbootstrap to improve wkhtmltox native resolution.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/dotnetcore.yml |
Reworked CI into change-detection + matrix test + final gate; adds log/artifact/diagnostic options. |
src/Magicodes.ExporterAndImporter.Tests/xunit.runner.json |
Disables parallel test collections and limits threads to 1 for more deterministic runs. |
src/Magicodes.ExporterAndImporter.Tests/Magicodes.IE.Tests.csproj |
Updates TFMs, adds GitHub Actions test logger package, and ensures xunit.runner.json is copied. |
src/Magicodes.ExporterAndImporter.Tests/PdfExporter_Tests.cs |
Tags PDF exporter tests with a Category trait. |
src/Magicodes.ExporterAndImporter.Tests/MagicodesMiddleware_Tests.cs |
Tags a PDF-related middleware test with a Category trait. |
src/Magicodes.ExporterAndImporter.Tests/ExcelTemplateExporter_Tests.cs |
Simplifies pre-delete logic for generated output files in two tests. |
src/Magicodes.ExporterAndImporter.Pdf/PdfNativeLibraryBootstrapper.cs |
Adds DllImportResolver registration to improve wkhtmltox native loading behavior and updates install guidance. |
src/Magicodes.ExporterAndImporter.Pdf/PdfExporter.cs |
Ensures native bootstrap executes before converter usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing CI workflow changes