Fix the Ch4 override value in the channel_overrides example - #1256
Open
Abhayindia wants to merge 1 commit into
Open
Abhayindia wants to merge 1 commit into
Abhayindia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while running the examples against SITL for the sweep in #1255.
channel_overrides.py:74prints "Set Ch1-Ch8 overrides to 110-810 respectively", but line 75 sets channel 4 to4100rather than410. It is also outside the 1000-2000 RC PWM range, so it is not a plausible value in its own right.The recorded sample output in
docs/examples/channel_overrides.rstcarried the same4100in three places. I regenerated those three lines from an actual Python 3 run rather than hand-editing them, which also fixes the key order: the old output was written under Python 2 dict ordering ('1', '3', '2', '5', '4', ...), and on Python 3.7+ dicts keep insertion order, so real output is now sequential.Verified against
dronekit-sitl copter(APM:Copter 3.3), exit 0:Branched off
masterso it is independent of #1253, though note that on currentmasterimport dronekitfails withModuleNotFoundError: No module named 'past', so #1253 has to be applied before any example can actually be run.