Fix multi-database annotation removal fixture targeting - #386
Merged
OdenTakashi merged 1 commit intoSep 14, 2026
Merged
Conversation
OdenTakashi
approved these changes
Sep 14, 2026
OdenTakashi
left a comment
OdenTakashi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this. Looks great to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotation removal always passes
klass.table_nameto related-file discovery. With multiple database classes sharing a table name, removing annotations from a secondary model can therefore target the primary database fixture. Match annotation behavior by supplying the table name only for the primary connection.Verified with the full 874-example unit suite on Ruby 4.0.6 and 3.2.11, the Rails 8.1 SQLite integration suite, StandardRB, and a focused multi-database removal model.