Repository navigation
[UI]: Fix filters changed mid-load - #4421
Merged
Merged
Conversation
When filters changed while a list page was loading, the previous request could finish after the new one and overwrite the table with items matching the old filters. A pending "load more" request could likewise append outdated items to the new list, and the outdated request could reset the loading flag while the new request was still running. Track a generation counter in useInfiniteScroll, incremented on every list reset, and ignore responses to requests from earlier generations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filters changed while a list page was
loading, the previous request could finish after
the new one and overwrite the table with items
matching the old filters. A pending "load more"
request could likewise append outdated items to
the new list, and the outdated request could reset
the loading flag while the new request was still
running.
Track a generation counter in useInfiniteScroll,
incremented on every list reset, and ignore
responses to requests from earlier generations.
Fixes #4413