Repository navigation
Report signals in job exit status - #4490
Merged
Merged
Conversation
When a signal killed the job's process, the runner reported exit status -1, the value of os.ProcessState.ExitCode() for any signal, and the job was shown as `exited (-1)`. The runner now reports -N for signal N, as Python's subprocess does. The server shows it as 128+N, which is what a forking shell or Docker reports, so a kill looks the same whichever shell the job runs in. -1 is shown as is, since older runners report it for any signal. A failed job without an exit status is now shown as `error` instead of `exited (None)`. Fixes: #4487 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a signal killed the job's process, the runner reported exit status -1, the value of os.ProcessState.ExitCode() for any signal, and the job was shown as
exited (-1).The runner now reports -N for signal N, as Python's subprocess does. The server shows it as 128+N, which is what a forking shell or Docker reports, so a kill looks the same whichever shell the job runs in. -1 is shown as is, since older runners report it for any signal.
A failed job without an exit status is now shown as
errorinstead ofexited (None).Fixes: #4487