Support new SWT dirty indicator in StackRenderer#3823
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
4c0f977 to
7b0d4db
Compare
7b0d4db to
72c6e7e
Compare
|
Is it intentional that this PR includes 2 commits one of which is about rounded corners? It's kind of confusing... |
72c6e7e to
598f07e
Compare
Adds a preference to enable the new bullet-style dirty indicator for tabs, which overlays the close button. - StackRenderer now calls setDirtyIndicatorStyle on CTabFolder level. - CTabItem.setShowDirty is updated on individual items. - Preference change at runtime is handled to update all visible stacks. - Asterisk prefix is skipped if the new indicator is enabled. - Reflection is used for the new SWT methods for compatibility. Fixes eclipse-platform#2568
598f07e to
fe1a1b4
Compare
fixed |
|
@schneidermic0 any feedback here? Can you help with testing this change? |
|
I personally think the black is a bit to strong for the light theme but that is currently hard-coded by SWT. Planning to merge tomorrow so that others can easily test. This is not yet the default, hence no change in the default L&F (without setting the preference). |
|
@vogella I saw the screenshot for this in the new and noteworthy and noticed a difference between light and dark theme. In the dark theme the inactive tab the dot is greyed out in the light theme it is the same black for active and inactive tab. Any chance that we can improve that? |
|
Yes. Can you create a short issue with some screenshots which I can use to understand your requirement? Implemention will be trivial. |
|

This change enables the new bullet-style dirty indicator for tabs in StackRenderer, which overlays the close button.
It implements the following:
This PR works with the changes introduced in eclipse-platform/eclipse.platform.swt#3141.