DO-NOT-MERGE-FOR-TESTING: Remove hard-coded button styling in workspace selection dialog#3918
Draft
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Draft
Conversation
…in workspace selection dialog Skip the early dark-theme styling for Button controls in the workspace selection dialog at startup so buttons get the native macOS dark appearance instead, matching what the ThemeEngine applies later. Other widgets (Shell, Composite, Label, Link, ExpandableComposite) remain styled as before since the ThemeEngine is not yet available during workspace selection. Test change for eclipse-platform#3905
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test PR for #3905.
The workspace selection dialog at IDE startup mimics dark-theme styling because the ThemeEngine is not yet available. On macOS this produces buttons that look different from the buttons on other dialogs (e.g.
File > Switch Workspace).This change skips the hard-coded dark styling for
Buttoncontrols only, so they get the native macOS dark appearance. All other widgets (Shell, Composite, Label, Link, ExpandableComposite) continue to be styled as before.Test plan
File > Switch Workspace.