Inline StatusUtil into StatusDialog in xml compare examples#2624
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Inline StatusUtil into StatusDialog in xml compare examples#2624vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
vogella
force-pushed
the
cleanup/compare-examples-statusutil
branch
from
ba1d014 to
640b6ca
Compare
StatusUtil#applyToStatusLine(MessageLine, IStatus) had a single caller (StatusDialog#updateStatus); the other public methods (getMoreSevere, getMostSevere, applyToStatusLine(DialogPage, IStatus)) had no callers in the repository. Inline the live method into the one caller and delete the class. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vogella
force-pushed
the
cleanup/compare-examples-statusutil
branch
from
640b6ca to
4085644
Compare
Contributor
Author
|
No idea why this is failing. Maybe related to eclipse-platform/eclipse.platform.releng.aggregator#3784? |
1 similar comment
Contributor
Author
|
No idea why this is failing. Maybe related to eclipse-platform/eclipse.platform.releng.aggregator#3784? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatusUtil#applyToStatusLine(MessageLine, IStatus)had a single caller (StatusDialog#updateStatus); the other three public methods (getMoreSevere,getMostSevere,applyToStatusLine(DialogPage, IStatus)) had no callers anywhere in the repository.StatusUtilentirely. Dead-code removal with no behavior change.org.eclipse.compare.examples.xml(example bundle).Test plan
mvn clean verify -Pbuild-individual-bundles -DskipTestsinteam/examples/org.eclipse.compare.examples.xml— BUILD SUCCESS.🤖 Generated with Claude Code