fix(vscode): lower vscode engine to ^1.105.0 and drop unused velocity bundle#58
Open
codersasha wants to merge 1 commit into
Open
Conversation
… bundle - engines.vscode ^1.106.0 -> ^1.105.0 so the extension installs on editors built on VS Code 1.105.x (e.g. Cursor 3.6.21 / VS Code 1.105.1). The code is typed against @types/vscode ^1.80.0, so no 1.106-only API is used. - remove ./server/org.apache.velocity.engine-core.jar from javaExtensions: the p2 repo ships no such bundle (so it is never packaged in the VSIX) and no Salesforce bundle requires Velocity. The dangling entry makes BundleUtils.loadBundles abort the whole plugin set on a clean JDT workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to
vscode/package.json.1. Lower the VS Code engine floor to
^1.105.0.^1.106.0stops the extension installing on editors still on 1.105 — notably Cursor, which runs VS Code 1.105.1. The floor doesn't need to be that high: the extension is typed against@types/vscode ^1.80.0, so it never touches a 1.106 API.2. Drop
org.apache.velocity.engine-core.jarfromjavaExtensions.It's a dead reference. The p2 repo has no such bundle, so
scripts/server.mjsnever packages it (the VSIX ships 9 of the 10 listed jars), and nothing in the Salesforce bundles imports Velocity. ButBundleUtils.loadBundlesaborts the whole set if a single jar is missing — so on a clean JDT workspace this one bad entry stops the entire Bazel plugin from loading, and nothing resolves. Removing the line fixes it.