Skip to content

fix: harden reruns and pin checks of release workflows #92

Closed
4 of 4 issues completed
Closed

Description

@uniqueg

Why?

Sourcery's review of elixir-cloud-aai/drs-filer#130 (release workflow ported from trs-filer) found two gaps that apply to every repo with the same release.yml and scripts/check_release_pins.py: trs-filer, proTES, cloud-registry and drs-filer.

What?

  1. Re-running all jobs of an already published (immutable) release: publish moves the X.Y.Z (and possibly latest) image tag to a new digest in "Tag image" before "Create release" (release_assets.py state) rejects the re-packaged chart. The run fails, but the image tag already points to a digest that no release contains. Fix: determine the release state before "Attest build provenance" / "Tag image", and fail early (or skip retagging) for a published release whose assets would change.
  2. check_release_pins.py checks requirement strings only: a [tool.uv.sources] override (VCS, URL or path) or a non-registry source in uv.lock passes the check and ends up in the image. Fix: reject such sources too.

Either move the shared parts into an action or reusable workflow here, or fix each repo (one PR per repo, sub-issues of this one).

Done when

  • A rerun of a published release fails before any image tag moves, in every repo with this workflow (tested).
  • The pin check rejects [tool.uv.sources] overrides and non-registry lock sources (tested).

Activity

  1. added and removed
    status: triageHas not been triaged by admin
    on Nov 18, 2026
  2. self-assigned this
    on Nov 18, 2026
  3. moved this from Backlog to In progress in ELIXIR On-Cloud: Low Priorityon Nov 18, 2026
  4. added
    status: triageHas not been triaged by admin
    and removed on Nov 18, 2026
  5. moved this from In progress to Tracking in ELIXIR On-Cloud: Low Priorityon Nov 18, 2026
  6. uniqueg commented on Nov 19, 2026

    @uniqueg
    MemberAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions