Skip to content

test(webapp): run all federated training specs with one command - #1256

Merged
ale18V merged 3 commits into
test/browser-browser-cypress-cifrom
test/federated-e2e-command
Oct 20, 2026
Merged

ale18V merged 3 commits into
test/browser-browser-cypress-cifrom
test/federated-e2e-command

Conversation

@ale18V

@ale18V ale18V commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

What & why

Add one package command to run both federated webapp training specs locally. The command starts a real server with Titanic and four-epoch LUS COVID, plus a Node participant for each task. Titanic's Cypress spec now selects its task explicitly when both tasks are visible. The command passed locally under Node 22 with both specs passing.

Technical plan

Extend the existing federated peer entrypoint with an all-tasks mode, and reuse the current server/Vite/Cypress orchestration pattern. Keep CI's per-task matrix unchanged so those jobs remain parallel.

Deviations from plan

Plan assumed the default Cypress browser; the local command uses Firefox because headless Electron stalled during LUS training without WebGL support.

Todo

None.

@ale18V
ale18V requested a review from JulienVig October 11, 2026 10:39
@ale18V
ale18V added this pull request to stack #1257 October 11, 2026 10:39
@ale18V
ale18V force-pushed the test/federated-e2e-command branch from 1c63cf7 to 1151938 Compare October 12, 2026 12:25
@ale18V
ale18V force-pushed the test/federated-e2e-command branch from 1151938 to f57470e Compare October 15, 2026 11:01

@JulienVig JulienVig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, only minor comments, thanks!

Comment thread webapp/cypress/e2e/training/federated/titanic.cy.ts Outdated
Comment thread docs/CONTRIBUTING.md Outdated
Comment thread webapp/package.json
Comment thread webapp/cypress/support/training/federated/peer.ts Outdated
@ale18V
ale18V force-pushed the test/federated-e2e-command branch from f57470e to d598eb2 Compare October 20, 2026 11:14
@ale18V

ale18V commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Merging this to clear the backlog a bit. Electron was indeed not working as browser for training tests on my system due to WebGL not being available (unlike in the CI where we use xvbf).
I set firefox as default browser but I think we should make it selectable through an env variable as chrome could work as well.

Integrating this as part of a broader change within cypress in #1266

@ale18V
ale18V merged commit fe6030a into main Oct 20, 2026
40 of 41 checks passed
@ale18V
ale18V deleted the test/federated-e2e-command branch October 20, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants