Skip to content

fix(group): use array-aware middleware on /group/participant#100

Open
netoduwe wants to merge 1 commit into
evolution-foundation:mainfrom
netoduwe:netoduwe-patch-1
Open

fix(group): use array-aware middleware on /group/participant#100
netoduwe wants to merge 1 commit into
evolution-foundation:mainfrom
netoduwe:netoduwe-patch-1

Conversation

@netoduwe

@netoduwe netoduwe commented Jul 3, 2026

Copy link
Copy Markdown

POST /group/participant was registered with ValidateJIDFields("number", "participants"), which only handles single-string fields. Because participants is an array, the type assertion fails and every request is rejected with 400 "participants is required and cannot be empty" before reaching the UpdateParticipant handler — breaking all participant actions (add / remove / promote / demote).

This swaps to ValidateMultipleNumbers("participants") — the same array-aware middleware already used by /group/create for the same field — and drops the unused "number" argument.

Reproduced on v0.6.1, 0.7.0, 0.7.1 and current main.

Related Issue

Closes #97

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Summary by Sourcery

Bug Fixes:

  • Correct validation middleware for POST /group/participant to accept an array of participants instead of rejecting all requests.

The /group/participant route used ValidateJIDFields, which only handles single-string fields. Since participants is an array, every request was rejected with 400 "participants is required and cannot be empty" before reaching the handler. Switched to ValidateMultipleNumbers (same middleware /group/create uses) and dropped the unused "number" field.
@sourcery-ai

sourcery-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes participant-related group actions by switching the /group/participant route to use the array-aware JID validation middleware consistent with /group/create, ensuring the participants array is validated correctly instead of being rejected by single-field middleware.

Flow diagram for updated /group/participant middleware validation

flowchart LR
    A[Client POST /group/participant] --> B[ValidateMultipleNumbers participants]
    B -->|valid participants array| C[UpdateParticipant]
    B -->|invalid or empty participants| D[400 Bad Request]

    %% highlight consistency with create route
    E[Client POST /group/create] --> F[ValidateMultipleNumbers participants]
    F -->|valid| G[CreateGroup]
    F -->|invalid| D
Loading

File-Level Changes

Change Details Files
Use array-aware JID validation middleware for the /group/participant route so participant actions work with the participants array payload.
  • Replaced single-string JID validation middleware with array-aware validation for the participants field on the /group/participant POST route.
  • Removed the unused number field from the JID validation call for the participant route.
  • Aligned participant route validation behavior with the existing /group/create route, which already uses array-aware validation for participants.
pkg/routes/routes.go

Assessment against linked issues

Issue Objective Addressed Explanation
#97 Update the POST /group/participant route to use an array-aware validation middleware for the participants field (ValidateMultipleNumbers("participants")) instead of the single-string middleware (ValidateJIDFields("number", "participants")), thereby allowing participant actions to succeed.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POST /group/participant always returns 400 "participants is required and cannot be empty" (wrong validation middleware on route)

1 participant