Skip to content

refactor: Remove unused constants - #205

Closed
ftnext wants to merge 1 commit into
executablebooks:mainfrom
ftnext:octicon-role-unused-constants
Closed

ftnext wants to merge 1 commit into
executablebooks:mainfrom
ftnext:octicon-role-unused-constants

Conversation

@ftnext

@ftnext ftnext commented Jul 1, 2024

Copy link
Copy Markdown

Thank you for this awesome library.
I referred to the implementation of the octicon role in icons.py (a3bdfa3).

In reading the implementation, I noticed some unused code, so I propose to remove it.

$ git grep OCTICON_CSS
sphinx_design/icons.py:OCTICON_CSS = """\
$ git grep OCTICON_VERSION
sphinx_design/icons.py:OCTICON_VERSION = "v19.8.0"

chrisjsewell added a commit that referenced this pull request Jul 12, 2026
Carries #205: removes the unused OCTICON_VERSION and OCTICON_CSS constants from icons.py.

Copy link
Copy Markdown
Member

Thanks @ftnext for the tidy-up, and apologies it sat for so long! Your change has landed on main via #266 (81dbab8) with your commit authorship preserved — the original branch here couldn't re-trigger the status checks that are now required (the 2024 CI runs were too old to re-run), so it was re-created rather than merged directly. Closing this one. 🙏


Generated by Claude Code

@ftnext
ftnext deleted the octicon-role-unused-constants branch July 12, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants