Repository navigation
Limit copying _sphinx_design_static to HTML based builders - #241
Closed
intelkevinputnam wants to merge 3 commits into
Closed
intelkevinputnam wants to merge 3 commits into
intelkevinputnam wants to merge 3 commits into
Conversation
Signed-off-by: Putnam, Kevin <kevin.putnam@intel.com>
Signed-off-by: Putnam, Kevin <kevin.putnam@intel.com>
for more information, see https://pre-commit.ci
This was referenced Jul 12, 2026
Member
|
Thanks @intelkevinputnam for this, and apologies it sat unreviewed for so long. #276 has now landed, which reworks the static-asset handling wholesale to go through Sphinx's standard Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #200, the
_sphinx_design_staticdirectory gets added to the output of all build targets, whereas it ought to only be added for HTML based targets. This PR adds anifstatement todef update_css_js(app: Sphinx):to fix this.Also includes fix from #237 to make RTD check work.