Fix node ownership when display: contents is used#56422
Open
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Open
Fix node ownership when display: contents is used#56422j-piasecki wants to merge 1 commit intofacebook:mainfrom
display: contents is used#56422j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [GENERAL][FIXED] Fixed Yoga node ownership when `display: contents` is used in absolutely positioned subtrees Fixes an edge case where nodes with `display: contents` weren't cloned properly inside absolutely positioned subtrees. Adds a test case covering this scenario. X-link: facebook/yoga#1924 Differential Revision: D100581579 Pulled By: j-piasecki
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100581579. |
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Software Mansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [GENERAL][FIXED] Fixed Yoga node ownership when
display: contentsis used in absolutely positioned subtreesFixes an edge case where nodes with
display: contentsweren't cloned properly inside absolutely positioned subtrees.Adds a test case covering this scenario.
X-link: facebook/yoga#1924
Differential Revision: D100581579
Pulled By: j-piasecki