Skip reporting benchmark results in test mode#56435
Closed
rubennorte wants to merge 1 commit intofacebook:mainfrom
Closed
Skip reporting benchmark results in test mode#56435rubennorte wants to merge 1 commit intofacebook:mainfrom
rubennorte wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Avoid printing the result summary table when benchmarks are executed in test mode. In test mode, benchmarks run only a single iteration with no warmup, so the timing results are not meaningful for comparison. The per-suite results table (console.table) was already skipped in test mode, but the benchmark result was still reported to the runner, which could cause the cross-variant comparison table to be printed with meaningless data. This change skips the reportBenchmarkResult call entirely when running in test mode. Changelog: [Internal] Differential Revision: D100795458
meta-cla
bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100795458. |
Collaborator
|
This pull request was successfully merged by @rubennorte in c482b93 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in c482b93. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Avoid printing the result summary table when benchmarks are executed in
test mode. In test mode, benchmarks run only a single iteration with no
warmup, so the timing results are not meaningful for comparison.
The per-suite results table (console.table) was already skipped in test
mode, but the benchmark result was still reported to the runner, which
could cause the cross-variant comparison table to be printed with
meaningless data. This change skips the reportBenchmarkResult call
entirely when running in test mode.
Changelog: [Internal]
Differential Revision: D100795458