Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
fail-fast: false # don't fail all matrix builds if one fails
matrix:
ruby:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ plugins:
- rubocop-rake

AllCops:
TargetRubyVersion: 3.1
TargetRubyVersion: 3.2
NewCops: enable

# Suppress noise for obvious operator precedence.
Expand Down
3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ gem 'test-unit', '3.7.7'
gem 'timecop', '0.9.11'
gem 'yard', '0.9.40'

# TODO: remove when Ruby 3.1 is no longer supported
gem 'erb', '~> 4.0.4'

group :benchmark do
gem 'benchmark'
gem 'benchmark-ips'
Expand Down
1 change: 0 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ PLATFORMS
DEPENDENCIES
benchmark
benchmark-ips
erb (~> 4.0.4)
faker!
irb
minitest (= 5.27.0)
Expand Down
2 changes: 1 addition & 1 deletion faker.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.bindir = 'bin'
spec.executables = ['faker']
spec.require_paths = ['lib']
spec.required_ruby_version = '>= 3.1'
spec.required_ruby_version = '>= 3.2'

spec.metadata['changelog_uri'] = 'https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md'
spec.metadata['source_code_uri'] = 'https://github.com/faker-ruby/faker'
Expand Down
4 changes: 2 additions & 2 deletions lib/faker/default/driving_licence.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ def northern_irish_driving_licence
# Faker::DrivingLicence.uk_driving_licence #=> "70702548"
#
# @faker.version 1.9.2
def uk_driving_licence(*args)
def uk_driving_licence(*)
if Faker::Config.random.rand < NI_CHANCE
northern_irish_driving_licence
else
british_driving_licence(*args)
british_driving_licence(*)
end
end

Expand Down
2 changes: 0 additions & 2 deletions lib/helpers/positional_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ def build_graph
# [2]
# ]
def build_stack(graph)
require 'set'

terminals = graph.filter_map { |(from, to)| to.nil? && from }
stack = [terminals]
seen = Set.new(terminals)
Expand Down