Bug Fix: test_faker_bird Unit Test Failure due to Apostrophe - #3312
Open
jremes-foss wants to merge 1 commit into
Open
Bug Fix: test_faker_bird Unit Test Failure due to Apostrophe#3312jremes-foss wants to merge 1 commit into
jremes-foss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
It looks like
test_faker_bird.rbfails on certain cases with Ruby 3.2, Ruby 3.3 and Ruby Head. This is due to an underlying bug in howFaker::Creature::Birdformats names and differences in random sampling and execution order across different Ruby versions.The test fails due to apostrophe here:
As a side effect of
.capitalize, the methodFaker::Creature::Bird#implausible_common_namecalls.capitalizeon the resulting string. In Ruby,String#capitalizeforces the very first character to uppercase and all subsequent characters to lowercase which yields a regex match failure. This PR fixes the match failure by taking the apostrophe into account.Additional information
This issue forms a blocker to subsequent pull requests and should be considered a priority. Unblocks #3307.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]