Famedly release/v1.153#17
Merged
Merged
Conversation
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Synapse PR: element-hq/synapse#18475 For [MSC4163](matrix-org/matrix-spec-proposals#4163) Supercedes matrix-org#783
…-org#865) Follow-up to matrix-org#830 As experienced in https://github.com/element-hq/synapse-rust-apps/actions/runs/24910122124/job/72949760158?pr=360 (element-hq/synapse-rust-apps#360) ``` ❌ TestDelayedEvents/delayed_state_events_are_kept_on_server_restart (10.12s) delayed_event_test.go:425: StopServer hs1 delayed_event_test.go:429: StartServer hs1 delayed_event_test.go:443: CSAPI.MustDo GET http://127.0.0.1:32978/_matrix/client/v3/rooms/%21MbDncghrqxTzEmQhCP:hs1/state/com.example.test/1 returned non-2xx code: 404 Not Found - body: {"errcode":"M_NOT_FOUND","error":"Event not found."} ``` This is most likely caused because the main process handles processing delayed events (and serving `/state`) but the state will be persisted on one of event_persister workers so the main process might be serving stale data until the invalidation comes through.
…matrix-org#865)" (matrix-org#867) This reverts commit cea922e.
…ontext` `start` token (matrix-org#853) Follow-up to matrix-org#852
--------- Signed-off-by: Thomas Traineau t.traineau@famedly.com
…ke v2) (matrix-org#869) Re-introducing the changes from matrix-org#865 which were reverted in matrix-org#867 Follow-up to matrix-org#830 As experienced when running this test against the worker-based Synapse setup we use alongside the Synapse Pro Rust apps, https://github.com/element-hq/synapse-rust-apps/actions/runs/24910122124/job/72949760158?pr=360 (element-hq/synapse-rust-apps#360) ``` ❌ TestDelayedEvents/delayed_state_events_are_kept_on_server_restart (10.12s) delayed_event_test.go:425: StopServer hs1 delayed_event_test.go:429: StartServer hs1 delayed_event_test.go:443: CSAPI.MustDo GET http://127.0.0.1:32978/_matrix/client/v3/rooms/%21MbDncghrqxTzEmQhCP:hs1/state/com.example.test/1 returned non-2xx code: 404 Not Found - body: {"errcode":"M_NOT_FOUND","error":"Event not found."} ``` Also updating the rest of the `TestDelayedEvents` tests to better account for state changes that might not show up immediately because processing/worker/replication delay ### Why does this flake happen? Discussed in matrix-org#865 (comment)
jason-famedly
approved these changes
May 27, 2026
jason-famedly
left a comment
jason-famedly
left a comment
Member
There was a problem hiding this comment.
Tests seem happy so I guess this is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.