Reapply "Update build review" - #7
Merged
Merged
Conversation
This reverts commit 6794a90.
Now used as test-command for cibuildwheel
flaviomartins
force-pushed
the
update_build_1
branch
from
September 11, 2026 00:11
a6c7ea2 to
0c042d9
Compare
Collaborator
|
@flaviomartins thank you, it is ok to merge this one I assume? |
Contributor
Author
|
Yes. CI is all green. Ready for merging. |
Contributor
Author
|
To finish the job and upload/publish to pypi you will need to |
No compiled code actually calls the OpenMP runtime; -fopenmp merely forces the linker dependency, and auditwheel then bundles libgomp
Contributor
Author
|
@searchivarius I managed to add in a few small commits before the merge. This is now ready to merge. |
Contributor
Author
@searchivarius you might need to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6794a90.
(See: #5)