Fix fedify init Astro + Bun projects#707
Fix fedify init Astro + Bun projects#707dahlia wants to merge 5 commits intofedify-dev:2.1-maintenancefrom
fedify init Astro + Bun projects#707Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces Bun runtime support for Astro projects by updating the @fedify/init package and adding a Bun-specific example configuration. A review comment points out that the server and security settings in the new example configuration are incorrectly defined and should be removed.
Switch Astro projects generated for Bun from the Node.js adapter to @nurodev/astro-bun and run the built Bun server entry point for preview. Update the Astro example and package documentation to cover the Bun setup, and record the bug fix in CHANGES.md. Assisted-by: OpenCode:gpt-5.4
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Fixes fedify init scaffolding for Astro projects targeting Bun by switching to a Bun-compatible adapter and aligning generated configs/scripts/docs to run the built Bun server entry point.
Changes:
- Update
@fedify/initAstro initializer to use@nurodev/astro-bunfor Bun and to generate a Bun-specific Astro config template. - Update
@fedify/astrodocumentation to include Bun setup instructions and correct the Deno adapter reference. - Extend the
examples/astroproject with Bun config/scripts and add the Bun adapter dependency; update changelog anddeno.lock.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/init/src/webframeworks/astro.ts | Select Bun adapter deps, pick Bun config template, and run built Bun entry for preview. |
| packages/init/src/templates/astro/astro.config.bun.ts.tpl | New Astro config template using @nurodev/astro-bun. |
| packages/astro/README.md | Add Bun setup docs and fix Deno adapter naming. |
| examples/astro/package.json | Add Bun scripts and dependency on @nurodev/astro-bun. |
| examples/astro/astro.config.bun.ts | Add Bun-specific Astro config for the example. |
| examples/astro/README.md | Document Bun runtime usage and template instructions. |
| deno.lock | Lock updated for new adapter dependency chain. |
| CHANGES.md | Record the @fedify/init bug fix. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Adjust the Deno and Node.js template instructions in the Astro example so they also remove the Bun config file. This keeps the documented cleanup steps aligned with the new astro.config.bun.ts file added in the previous fix. Assisted-by: OpenCode:gpt-5.4
|
@codex review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces Bun runtime support for Astro projects within the Fedify ecosystem. Key changes include updating @fedify/init to generate Bun-compatible configurations using @nurodev/astro-bun, adding Bun-specific scripts and configuration templates to the Astro example, and updating documentation across the repository. Feedback indicates that the changelog entry is missing required PR references and author credits as specified in the repository style guide. Additionally, an invalid security configuration property was identified in the new Bun configuration file and should be removed.
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add a regression test for the Astro initializer's Bun path so changes to its adapter dependency, generated config, or preview command stay covered by the init package test suite. Assisted-by: OpenCode:gpt-5.4
|
@codex review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Bun runtime in Astro projects. It updates @fedify/init to correctly generate projects using the @nurodev/astro-bun adapter and includes Bun-specific configurations, scripts, and documentation. A type error was identified in the security configuration of the new Astro Bun example where allowedDomains was incorrectly initialized with an object instead of a string array.
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2chanhaeng
left a comment
There was a problem hiding this comment.
I think it would be better if you change these!
Use the shared package-manager-to-runtime helper in the Astro initializer instead of duplicating the runtime mapping inline. This keeps the template selection logic aligned with the existing utility used elsewhere in the init package. Assisted-by: OpenCode:gpt-5.4
Summary
@nurodev/astro-bunso projects generated byfedify initbuild and run correctly on Bun.bun ./dist/server/entry.mjsfor the built server.CHANGES.mdand updatedeno.lockfor the new adapter dependency.Testing
pnpm --filter @fedify/init buildpnpm --filter @fedify/init testbun run build:buninexamples/astrobun run preview:buninexamples/astro