Merged
Conversation
Closed
dahlia
requested changes
Apr 21, 2026
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Great, thanks for your work! Since this is a new feature, could you change the target of this pull request to branch main instead of stable?
aliceif
force-pushed
the
thumbnail_management
branch
from
dc1f74a to
5a06003
Compare
Contributor
Author
|
and, after some effort, rebased onto main... |
dahlia
requested changes
Apr 22, 2026
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Great work, thanks for your contribution! I left several review comments.
Also, could you add a changelog item to the CHANGES.md document?
use slicing logic to extract key use round-tripping characteristic to validate url
aliceif
force-pushed
the
thumbnail_management
branch
from
5f288cb to
a21a750
Compare
dahlia
requested changes
Apr 23, 2026
dahlia
approved these changes
Apr 23, 2026
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Thanks very much for your great work. It will be shipped with the next release, Hollo 0.8.0!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to implement a way to clean up old thumbnails from storage.
Idea here:
This is being done in a new page in the admin area titled "Thumbnail Cleanup":
The media table entry stays intact, so that the information of media existing does not get lost. In addition, some clients seem to (be able to) ignore thumbnails.
I have already tested it with both a locally hosted testing environment and my productive instance, on which it let me reclaim over 3GB out of 10GB storage used according to minio.
Related issue: #409