Skip to content

Move active_call search param after source - #221

Open
erayaydin wants to merge 1 commit into
mainfrom
fix/active-call-position
Open

Move active_call search param after source#221
erayaydin wants to merge 1 commit into
mainfrom
fix/active-call-position

Conversation

@erayaydin

Copy link
Copy Markdown
Member

Problem

The v3.7.0 schema sync (#218) added the active_call query parameter to searchEvents before the released source parameter. Since the generated search_events signature has no keyword-only marker (*), every param is positional-or-keyword:

def search_events(self, limit=None, ..., simulator=None, active_call=None, source=None)

Inserting active_call ahead of source shifts source by one position, so any caller passing arguments positionally would bind their source value to active_call.

@erayaydin
erayaydin requested a lite review from Copilot August 24, 2026 17:01
@erayaydin erayaydin self-assigned this Aug 24, 2026
@erayaydin erayaydin added the bug Something isn't working label Aug 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
3267 2342 72% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
fingerprint_server_sdk/api/fingerprint_api.py 84% 🟢
TOTAL 84% 🟢

updated for commit: 03597a6 by action🐍

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/python-sdk@9.7.0

Minor Changes

  • events-search: Add active_call filter parameter (e3164f0)
  • Add keyboard_layout_name to RawDeviceAttributes (e3164f0)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the search_events parameter ordering to restore backward compatibility for callers using positional arguments, after active_call was introduced ahead of the already-released source parameter.

Changes:

  • Reorders the active_call query parameter to come after source in the OpenAPI schema.
  • Regenerates/updates the Python FingerprintApi.search_events* method signatures and request serialization to match the corrected parameter order.
  • Updates tests and API docs to reflect the new ordering.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
res/fingerprint-server-api.yaml Moves active_call parameter definition after source to drive stable generated parameter ordering.
fingerprint_server_sdk/api/fingerprint_api.py Reorders active_call after source in search_events variants and serialization to fix positional binding.
test/test_fingerprint_api.py Updates expected query-param construction order to match the corrected API definition order.
docs/FingerprintApi.md Updates documented method signature / examples to reflect the corrected parameter order.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants