Move active_call search param after source - #221
Open
erayaydin wants to merge 1 commit into
Open
Conversation
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the search_events parameter ordering to restore backward compatibility for callers using positional arguments, after active_call was introduced ahead of the already-released source parameter.
Changes:
- Reorders the
active_callquery parameter to come aftersourcein the OpenAPI schema. - Regenerates/updates the Python
FingerprintApi.search_events*method signatures and request serialization to match the corrected parameter order. - Updates tests and API docs to reflect the new ordering.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
res/fingerprint-server-api.yaml |
Moves active_call parameter definition after source to drive stable generated parameter ordering. |
fingerprint_server_sdk/api/fingerprint_api.py |
Reorders active_call after source in search_events variants and serialization to fix positional binding. |
test/test_fingerprint_api.py |
Updates expected query-param construction order to match the corrected API definition order. |
docs/FingerprintApi.md |
Updates documented method signature / examples to reflect the corrected parameter order. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ilfa
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v3.7.0 schema sync (#218) added the
active_callquery parameter tosearchEventsbefore the releasedsourceparameter. Since the generatedsearch_eventssignature has no keyword-only marker (*), every param is positional-or-keyword:Inserting
active_callahead ofsourceshiftssourceby one position, so any caller passing arguments positionally would bind theirsourcevalue toactive_call.